Thank you!

Jump to navigation Jump to search
Revision as of 23 October 2013 at 19:29.
The highlighted comment was created in this revision.

Thank you!

I see you've just made major contributions to the Blockly translation. THANK YOU! Persian is one of the languages we've most wanted to see translated because of its large number of native speakers and paucity of native programming environments. Please let us know if you have any questions or see any problems in our RTL code (or anything else). The translated puzzle app has been up for a while.

    Espertus (talk)15:33, 23 October 2013

    WOW! Really am happy to hear that! But please consider that Google App Engine and Google Code is blocked on Iran (and the link you've provided is blocked for me due Google sanctions). Please consider to migrating to a more freedom place such as Github if is possible :)

      ebraminiotalk15:37, 23 October 2013

      Thank you for pointing that out. Blockly can run entirely client-side, but, as you point out, you do need to get the source code. I'm going to talk to the Google Code team to ask if Google is blocking Iran (I thought it was the other way around) and with my tech lead about a github mirror (although I guess I don't need anyone's permission because it's open source). I'll get back to you soon.

        Espertus (talk)15:48, 23 October 2013
         

        I opened that link somehow, the Persian language name is typed reveresed on the UI, it is "فارسی" not "پسراف". Can be fixed?

          ebraminiotalk15:45, 23 October 2013

          Thank you for pointing that out. I remember struggling with that because I wasn't sure how it should appear. Do you mean it is backward in the dropdown menu?

            Espertus (talk)15:49, 23 October 2013

            Yes completely reversed, something like

            "فارسی".split('').reverse().join('')
            

            ! (the string inside double quotation is correct and result of this js code is what is in UI and wrong!) :)

              ebraminiotalk15:54, 23 October 2013

              Thank you. I'll fix it today (although I don't know when it will get pushed).

              I confirmed that you are correct about Google blocking Iran. (I was hoping you were wrong.) I will find a way to get Blockly source code on github.

              I hope for peace between our countries.

                Espertus (talk)16:00, 23 October 2013

                In my opinion you should propose completely migrating to Github and not just cloning as the blocking problem is not just on Iran (and is available on other sanctioned countries) and contributing to Google code projects is impossible for users on those countries (like me). Notepad++ migrated from sourceforge just because for lifting up sanctions you should press a tick and this was unacceptable for Notepad++ author but Google Code has not this option even.

                I strongly hope also! :)

                  ebraminiotalk16:08, 23 October 2013

                  Could you tell me if this looks correct?

                  Blockly-puzzle-fa.png

                  I will share your feedback about Github, although I fear it's just a matter of time until "my" government makes them block sanctioned countries too.

                  Thanks again.

                    Espertus (talk)17:19, 23 October 2013
                     

                    Could you tell me if this looks correct?

                    Blockly-puzzle-fa.png

                    I will share your feedback about Github, although I fear it's just a matter of time until "my" government makes them block sanctioned countries too.

                    Thanks again.

                      Espertus (talk)17:19, 23 October 2013

                      It is not perfect, but it is usable as I solved the puzzle for myself! :) For example every text element on the page need direction: rtl; style but it also will change the position of the element.

                      I guess it won't happen soon. Github, Bitbucket and many others are several years are not doing that but Google Code was blocked from start day as I remember.

                        ebraminiotalk17:35, 23 October 2013

                        Is the appearance of the language name correct in the drop-down menu? Are the letters in the right order on the other blocks?

                        Could you clarify what else is imperfect? IIRC, my TL specifically doesn't use the rtl style because there are bugs in it in some browsers, but he tries to duplicate the functionality himself.

                          Espertus (talk)18:22, 23 October 2013

                          The text inside option is wrong. It is interesting that all other RTL languages seems are okay expect Persian. http://i.imgur.com/ZnoFI0Y.png Amir said what I wanted to say on the below :)

                            ebraminiotalk18:50, 23 October 2013

                            Right now there are two versions of the dropdown menu, the one on the live site and the one in this attached image:

                            Blockly-puzzle-fa.png

                            Could you tell me if one of them is correct and, if not, what would be correct?

                            Thanks.

                              Espertus (talk)19:29, 23 October 2013
                               
                               
                               
                               
                               
                               
                               
                               
                               

                              Hi Ellen,

                              I speak Hebrew and ebraminio asked me for more feedback about RTL support in Blockly.

                              In that puzzle most parts look fine. Immediate problems that I noticed:

                              • The colon in the end of "Flag:", "Language:", "Cities:" is on the wrong side. The CSS direction is ltr. It should be rtl.
                              • Similar problem with the ellipsis in "choose..." - the ellipsis is on the wrong side.
                                Amir E. Aharoni (talk)18:21, 23 October 2013

                                Thanks! My TL Neil is on it.

                                  Espertus (talk)18:50, 23 October 2013