TheWikipediaLibrary - json-based i18n files in addition to existing gettext

Fragment of a discussion from Support
Jump to navigation Jump to search

Would stripping them out everywhere (instead of adding them) be a good solution?

Yea, I'd just strip them out.

I also want to draw attention to this:

Could we skip the keys that don't have any definition such as: "24_description", "78_description"? These keys appear to be machine generated, can we assume that these keys will not change?

Regards,

Abijeet Patro (talk)05:21, 1 April 2021

Thanks for the feedback! We have updated our GitHub PR with all the suggestions you made: https://github.com/WikipediaLibrary/TWLight/pull/654. Let us know if you have any more additional feedback.

Suecarmol (talk)17:06, 1 April 2021
 

Okay, we've merged this in. It's ready to be included for translation so far as we're concerned. Let us know if there are any problems or unanswered questions.

Thanks!

Jsn.sherman (talk)17:49, 5 April 2021