Jump to content

Strings not marked for translation

I guess the code should be reviewed completely for hard coded strings, or is that how you did this?

Siebrand13:23, 4 December 2012

According to JohnMcLear it's a problem with plugins, which don't support l10n.

Nemo (talk)20:59, 4 December 2012

Then I guess it's about time they start doing that... Have a look at jQuery.i18n?

Siebrand21:35, 4 December 2012
 

I only did a quick etherpad-lite installation and reported untranslated strings visible to user. However, looking at https://github.com/ether/etherpad-lite/blob/master/src/templates/pad.html shows there are some hardcoded error/warning strings that most probably should have translations. Also the admin interface itself is untranslatable for most parts. And no, I did not do a through code review. Most of the strings I reported seem to be located in separate JS files, e.g.

  1. https://github.com/ether/etherpad-lite/blob/master/src/static/js/pad_userlist.js#L718
  2. https://github.com/ether/etherpad-lite/blob/master/src/static/js/pad_editbar.js#L172
  3. https://github.com/ether/etherpad-lite/blob/master/src/static/js/pad_savedrevs.js#L21
  4. https://github.com/ether/etherpad-lite/blob/master/src/static/js/pad_impexp.js#L109
  5. https://github.com/ether/etherpad-lite/blob/master/src/static/js/pad_impexp.js#L229
Artnay (talk)07:46, 5 December 2012

Looks like jQuery.i18n might be a very good match for Etherpad lite. Hope you can get the Etherpad lite devs to use it.

Siebrand15:44, 5 December 2012