Jump to content

Thanks for your patches

Thanks for your patches

You're being very helpful, thank you.

There has been some resistance to the changes to American spelling of some words that we have made recently. I think we should try to not fix comments in code, but focus on messages in the user interface only. Those really should be made consistent across MediaWiki core and extensions. It's de facto (i.e. not decreed, but in practice) American English spelling that we are using in the language code "en".

Siebrand18:54, 6 March 2013

I'll be careful from now on. About gerrit:52405, I've fixed it.

Shirayuki (talk)21:48, 6 March 2013
 

Thank you for the n-th time from me too :) and I hope you don't mind that I added three more ideas for small consistency/typofix patches that you can see in your userpage now. If you're not interested, edit the support template and "assign" them to me, thanks!

Nemo (talk)20:28, 21 July 2013

Sorry for closing some issues you had open patches for. Is this for you only, or for someone else to see? We usually try to avoid duplicating the tracking work of bugzilla and gerrit; you and your reviewers can see the open patches on the gerrit dashboard (e.g. siebrand's).

Nemo (talk)13:59, 29 July 2013

I know it. My patches could be rejected, so the issues should not be closed until the patches are approved.

Shirayuki (talk)23:25, 29 July 2013

Sure. Still, is this tracking for yourself or for others?

Nemo (talk)04:42, 30 July 2013
 
 

Wow, I see you now have more than 150 merged commits. I would never hoped for so much when I suggested to give a look to the git tutorial to submit some changes yourself. :D

Nemo (talk)09:00, 6 August 2013

150!? Thanks for telling me about the git tutorial. :)

Shirayuki (talk)12:21, 6 August 2013