Feedback from Waldir

The gadget should dynamically add a link to the terminology.json page from the Portal:kea page.

Jon Harald Søby (talk)23:23, 6 December 2021

Done Done

Jon Harald Søby (talk)01:12, 14 December 2021

Why dynamically? If it depends on {{Portal}} anyway (as it currently does), the template could add the whole link on its own, avoiding client-side JS and parts below the link moving down after the first paint.

Tacsipacsi (talk)07:28, 14 December 2021

@Tacsipacsi: Yes, I actually want to do that eventually when (fingers crossed) the gadget is ready to become a default gadget. But now in the beta stage, I think it is better to only show the link for those who have the gadget switched on. Users who don't have it switched on would only see the raw (well, prettified/tablified) JSON when visiting the terminology.json page, so I'm afraid that would just confuse people.

Jon Harald Søby (talk)10:45, 14 December 2021

Then what about adding it in the template with display:none, and unhiding it in the gadget’s CSS? That would still cause a flash after first paint as gadget CSS is loaded with JavaScript, but the hiding is easier and less error-prone to remove when the gadget becomes default, and it’s also faster as we can save the AJAX request loading the necessary MediaWiki messages. (The flash could be resolved by using a peer gadget, but I don’t think it’s worth the effort for this temporary solution.)

Tacsipacsi (talk)18:08, 14 December 2021

Sure, that sounds reasonable. Oh, and I didn't know about that peer thing, that sounds interesting – but I agree it's not worth the effort just for this.

Jon Harald Søby (talk)22:31, 14 December 2021