Error on Wikimedia:Citationhunt-instructions details/zh-hans

Error on Wikimedia:Citationhunt-instructions details/zh-hans

Hi, I'd like to request a review of Wikimedia:Citationhunt-instructions details/zh-hans please.

The original text is "Click %s to go to Wikipedia and {link_start}fix the snippet{link_end}, or %s to see another one. Good luck!", with two "%s" placeholders. The current translation only contains one "%s", which is not expected in the code. I can't read the translation but I wonder if the "or %s to see another one" part of the original message is missing?

Please let me know if there's another preferred way to report translation issues, I wasn't too sure. Thanks!

Surlycyborg (talk)18:35, 26 October 2020

I have marked the message as outdated. Currently missing parameters are only a warning, should we make this an error?

Nike (talk)09:13, 30 November 2020

Thank you! Yes, I think it would make sense to make it an error please. I suppose that means those strings will never be exported to the repository, right?

There's just a couple of things to watch out for, because this string handling code in Citation Hunt is not great:

  • As you can see from the example above, there are two kinds of syntax for parameters in some strings ({this} and %s).
  • Due to out of date translations, some strings now have _too many_, rather than too few parameters (e.g. https://translatewiki.net/wiki/Wikimedia:Citationhunt-instructions_details/pl has three %s, which we handle in the code, but it really should be two at this point).

But if those are OK on TranslateWiki, it's all good on my end.

Surlycyborg (talk)21:40, 30 November 2020