Typos etc.
Hello, thanks for all your reports at Support. In the cases where you have already identified a solution (such as typo fixes, but also slightly more complex cases), have you considered sending a patch yourself? It's very easy (I learnt in few hours with no prior VCS experience) and would make the solution much faster, letting me instead pester the devs more about your reports which require more work. ;-)
I would like to send patches, and you may know that I did so often in the past.
Currently, I cannot. Despite having had some help last year, switching to git etc. did not work for me. I shall try it again during the next days - thank you for giving me the kick - and if I still cannot get it working this time, I shall report.
Thanks for not giving up!
If all else fails, remember you can also use https://tools.wmflabs.org/gerrit-patch-uploader/ We have great contributors who never sent patches to gerrit directly.
My try to start from scratch ended wih: https://tools.wmflabs.org/purodha-testing/core/index.php?title=Haupsigg
I cannot find out how to get skins. (After spending ~4 hours searching)
All links to download something static are not for me™ :-) What I need are instructions on how to clone the common skins as a git repository. I was not even able to find where they are. I understand that once I have a git repository of skins, I can link (or even copy) them to the skins directory local to my test installation of MediaWiki and proceed with them. See also Thread:Support/ About MediaWiki:Default-skin-not-found/en and MediaWiki:Default-skin-not-found-no-skins/en
Apparently they want you to use composer: mw:Download_from_Git#Fetch_external_libraries
But you can also download all skins separately: mw:Download from Git#Using Git to download MediaWiki skins
No. That is not what I want to use. I want to use git, as I wrote.
With some luck, and by trial and error, I found git clone ssh://purodha@gerrit.wikimedia.org:29418/mediawiki/skins.git which now brought me an apparently all emply repository which also did not help.
I am a bit further as it seems, I can get core, all extensions and all skins via git.
Only git review refuses to work from individual extension or skin directories:
~/extensiions/Translate > git review
Enter passphrase for key '/home/.../.ssh/id_rsa':
Problems encountered installing commit-msg hook
/home/.../extensions/Translate/.git/hooks/commit-msg: Not a directory
protocol error: expected control record
~/extensiions/Translate >
It also does not work from the extensions directory itself:
~/extensiions > git review
Enter passphrase for key '/home/.../.ssh/id_rsa':
remote: Processing changes: refs: 1, done
To ssh://purodha@gerrit.wikimedia.org:29418/mediawiki/core.git
! [remote rejected] HEAD -> refs/for/master/master (no new changes)
error: failed to push some refs to 'ssh://purodha@gerrit.wikimedia.org:29418/mediawiki/core.git'
~/extensiions >
So again, nothing I can do. Btw. although there are lots of wiki pages that should describe all this, some say different things, nothing working for me.
Another problem: Some of my hint here could to to bugzilla, and they were there already had not bugzilla been discontinued. Yet phabricator lets me login, then tells me that is was sending me an e-mail to a wrong address → dead end.
Are you still working from tools? What instructions did you follow?
Maybe it's just a typo: you are in ~/extensiions/Translate but git review was looking for extensions/Translate/.git/ . I think mw:Gerrit/Tutorial#Configure_Git is supposed to help, too.
Too many instructions. I simply cannot remember them. There are many pages on git, gerrit, installing and downloading mediawiki, and so on in various wikis. Assume that I read them all.
The double i is just an issue coming from copying stuff here to this page. I reality, there are several directory names on several hosts (among them tools lab). I trashed directories when they were not working, always attempting as clean a start as possible.
mw:Gerrit/Tutorial is one of the many pages that I read. It has a bunch of errors and inconsistencies. What do I do with the issues that I found? Write them on the talk page?
I managed to submit a patch to core.
The gerrit web site says it was erroneous - that is at least how I interpret the -1 in the Code-Review column - and there were 2 comments on it in this context. How or where can I find these comments, and how to find out what is wrong?
You have to click on "Side-by-Side" to open the diff view for the corresponding file, for example: https://gerrit.wikimedia.org/r/#/c/198300/1/includes/skins/SkinFallbackTemplate.php There you can see the comment (in this case on the right side, but it is also possible to add it to the left). You can also reply there. To publish a added comment you have to add a (empty) comment to the whole patch set.
I managed to submit a patch to an extension few minutes ago.
I used a method, however, that does not scale. I downloaded the extension individually as a git repository and set it up to use git review. If I had to do that for each skin and extension, I had to type my key pass phrase 3060 times, spending almost 26 hours typing pass phrases without a break. With waiting times between the prompts, that would add up to some 56 to 62 hours, not counting sleeping times, that is more than a working week. I refuse to do that. There must be a better solution.