Link source code lines

Link source code lines

I just dug up a source code file to better understand the context of a message and add its /qqq description. Since you display here the path to the file and even the specific line for the message, what do you think about making that snippet link to the source? Since the projects here at twn are open source, I assume most would have their source files available for viewing on the browser, and the urls (including anchors!) are easily constructed from the data you have. What do you think? :)

Waldir (talk)11:57, 24 August 2010

Possible, but has very low priority, unless you are offering to implement it, have someone readily available to implement it, or can sponsor the implementation. Also see Issues_and_features and Roadmap.

Siebrand12:12, 24 August 2010

Indeed, none of those apply. So, can I add that to the Issues and features page (as a P3)? If so, please advise as I am unsure where to place it: "Primarily for translatewiki.net" > Features"? Or perhaps "More information needed or uncertain issues"?

Waldir (talk)09:00, 8 September 2010

It looks like someone did that, at least for StatusNet. Thanks!

Waldir (talk)12:55, 15 September 2010

Niklas got crazy and just did it. I think mwlibrl also supports it (gettext only feature).

Siebrand13:48, 15 September 2010
 

Yay someone noticed! I got feedback that there is too little contrast with link colors and the background. Imho they don't need to catch attention, just to be somewhat readable and able to be clicked. What do you think about this? Is it good enough or can it be improved?

Also, does it cause problems that the links take you to another page and you (may) lose the current translation?

Nike14:43, 15 September 2010

In my browser (Firefox) the links have the same colour as the other text, and aren't underlined either unless you hover the mouse over them, so it would have taken a while for me to discover them. Otherwise this seems great.

I get around the problem of losing the translation by leaving the page by right-clicking on the link and opening the page in a new tab.

McDutchie15:03, 15 September 2010

I think Ctrl+click does the same in most browsers.

Nike15:05, 15 September 2010

I've been thinking about this issue, too. If it's not too big of a thing, I'd prefer this code to open in a new tab, as is done with the show history button.

Siebrand15:09, 15 September 2010

I use middle-click to that effect, but having that as default would be good, I think.

As for the links, perhaps simply underlining them (all the time, not only on hover) would suffice.

Waldir (talk)20:50, 15 September 2010

As in making them different from all the other links? Doesn't the external link icon give them away?

Nike20:52, 15 September 2010

The JS editor does not markup external links differently.

Siebrand21:01, 15 September 2010

I wonder why not.

Nike15:48, 16 September 2010